Skip to content

fix(config): infinite loop on spotify_launch_flags and non-deterministic extension ordering #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nghiphaam wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(config): infinite loop on spotify_launch_flags and non-deterministic extension ordering #3847

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505cf03
fix(config): infinite loop on spotify_launch_flags and non-determinis…
nghiphaam May 20, 2026
dd2723b
Merge branch 'main' into fix/config-loop-ordering
nghiphaam May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cmd/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"log"
"os"
"sort"
"strings"

"github.com/go-ini/ini"
Expand All @@ -20,7 +21,7 @@ func EditConfig(args []string) {
case "extensions", "custom_apps":
arrayType(featureSection, field, value)
case "spotify_launch_flags":
continue
// not editable via config command
case "prefs_path", "spotify_path", "current_theme", "color_scheme":
stringType(settingSection, field, value)

Expand Down Expand Up @@ -178,6 +179,7 @@ func arrayType(section *ini.Section, field, value string) {
for k := range allExts {
newList = append(newList, k)
}
sort.Strings(newList)

key.SetValue(strings.Join(newList, "|"))
changeSuccess(field, strings.Join(newList, "|"))
Expand Down