Skip to content

fix(core/title): detect id="title" collision and use fallback #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcoscaceres wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(core/title): detect id="title" collision and use fallback #5285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/core/title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,18 @@ export function run(conf) {
}

// Decorate the spec title
if (!h1Elem.id) h1Elem.id = "title";
if (!h1Elem.id) {
const existing = document.getElementById("title");
if (existing && existing !== h1Elem) {
const msg =
'Another element already uses `id="title"`. ' +
"The spec's `<h1>` will use a different id to avoid a collision.";
showError(msg, name, { elements: [existing] });
h1Elem.id = "document-title";
} else {
h1Elem.id = "title";
}
}
h1Elem.classList.add("title");

setDocumentTitle(conf, h1Elem);
Expand Down