Fix role member bulk update semantics#1637
Closed
samuelscheit wants to merge 4 commits intospacebarchat:masterfrom
Closed
Fix role member bulk update semantics#1637samuelscheit wants to merge 4 commits intospacebarchat:masterfrom
samuelscheit wants to merge 4 commits intospacebarchat:masterfrom
Conversation
Member
Author
|
Code review: no blocking issues found. The PATCH/PUT split addresses the root cause, the shared request schema is wired into the generated docs, and the regression tests cover the key semantics. From a code-review standpoint this change is approved. |
Member
Author
|
PR report: Changed files:
Tests run:
Test results:
Code review outcome:
Decision:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /guilds/:guild_id/roles/:role_id/membersreplacement semantics while keepingPATCHadditive-onlymember_idswith a sharedRoleMembersUpdateSchemaand expose it in generated schema/OpenAPI outputRoot cause
The old
PATCHroute used a singlearrayPartition(...)across all guild members and treated every non-addition as a removal. That meant omitted current holders were removed, listed holders could still fall into the remove set, and unrelated non-holders still hitremoveRolecalls.Validation
npm run build:src:tsgonpm run generate:schemanpm run generate:openapinpm run node:testsCloses #445.