Skip to content

feat(p2p): log the resolved iroh relay set at endpoint spawn#1082

Merged
jackzampolin merged 1 commit into
mainfrom
fix/iroh-1.0-relay-openpath-flood
Jul 6, 2026
Merged

feat(p2p): log the resolved iroh relay set at endpoint spawn#1082
jackzampolin merged 1 commit into
mainfrom
fix/iroh-1.0-relay-openpath-flood

Conversation

@jackzampolin

@jackzampolin jackzampolin commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Why

Follow-up to the defra-agent#588 incident (relay open_path flood against unreachable n0 canary relays). During the incident nothing in the logs showed which relay infrastructure the endpoint was pointed at — canary vs production was invisible at default verbosity.

What

Slimmed down after #1084 merged (which landed the iroh 1.0.1 / gossip 0.101 / blobs 0.103 / tickets 1.0.0 bump this PR originally carried — thanks!). What remains is the observability piece: log the resolved relay URL set once at spawn_endpoint in crates/p2p/src/iroh/endpoint.rs, so every deployment shows its relay infrastructure at startup.

Verification

The fix/iroh-1.0-on-v0.15.1 branch mentioned earlier is now obsolete (defra-agent pins the #1084 merge rev directly) — I'll delete it.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 29ee6c93-77a7-463a-9f94-527b06c3aa99

📥 Commits

Reviewing files that changed from the base of the PR and between 407985f and df9299c.

📒 Files selected for processing (1)
  • crates/p2p/src/iroh/endpoint.rs
✅ Files skipped from review due to trivial changes (1)
  • crates/p2p/src/iroh/endpoint.rs
📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Build & Test

📝 Walkthrough

Walkthrough

In spawn_endpoint, relay URLs derived from relay_mode are collected into a Vec<String> and logged via tracing::info! before the iroh endpoint is built and bound. No other logic changes were made.

Changes

Relay Logging

Layer / File(s) Summary
Relay configuration logging
crates/p2p/src/iroh/endpoint.rs
Relay URLs from relay_mode are collected into a Vec<String> and logged via tracing::info! prior to building/binding the endpoint.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jackzampolin

Copy link
Copy Markdown
Collaborator Author

Also pushed fix/iroh-1.0-on-v0.15.1 (= v0.15.1 + this commit cherry-picked, fca7c36) so defra-agent can rev-pin the incident fix without absorbing unrelated main drift; defra-agent will switch to the next tag once this merges. Feel free to delete that branch after a v0.15.3 (or equivalent) tag exists.

During the defra-agent#588 incident the host was flooded by relay
open_path retries against n0 canary relays — and nothing in the logs
showed which relay infrastructure the endpoint was pointed at. Log the
resolved relay URL set once at spawn so canary/staging vs production is
visible in every deployment.

(The iroh 1.0.1 bump originally on this branch landed via #1084.)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jackzampolin jackzampolin force-pushed the fix/iroh-1.0-relay-openpath-flood branch from 407985f to df9299c Compare July 1, 2026 22:33
@jackzampolin jackzampolin changed the title fix(p2p): bump iroh to 1.0 stable — production relays + open_path backoff feat(p2p): log the resolved iroh relay set at endpoint spawn Jul 1, 2026
@jackzampolin jackzampolin merged commit 6d322b2 into main Jul 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants