Skip to content

Initialize the working_issuer_name with the subject name of the trust anchor #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zll600 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialize the working_issuer_name with the subject name of the trust anchor #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/X509/CertificationPath/PathValidation/ValidatorState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public static function initialize(PathValidationConfig $config,
$state->_workingPublicKey = $tbsCert->subjectPublicKeyInfo();
$state->_workingPublicKeyParameters = self::getAlgorithmParameters(
$state->_workingPublicKey->algorithmIdentifier());
$state->_workingIssuerName = $tbsCert->issuer();
$state->_workingIssuerName = $tbsCert->subject();
$state->_maxPathLength = $config->maxLength();
return $state;
}
Expand Down
10 changes: 10 additions & 0 deletions test/unit/certification-path/CertificationPathValidationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,16 @@ public function testExplicitTrustAnchor()
$validator->validate());
}

public function testExplicitTrustAnchorWithIntermediateCertificate()
{
$config = PathValidationConfig::defaultConfig()->withTrustAnchor(
self::$_path->certificates()[1]);
$validator = new PathValidator(Crypto::getDefault(), $config,
...[self::$_path->certificates()[2]]);
$this->assertInstanceOf(PathValidationResult::class,
$validator->validate());
}

public function testValidateFailNoCerts()
{
$validator = new PathValidator(Crypto::getDefault(),
Expand Down