[CI] Add libnexthopgroup to CI pipeline for swss compilation#1908
[CI] Add libnexthopgroup to CI pipeline for swss compilation#1908GaladrielZhao wants to merge 1 commit into
Conversation
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No Azure DevOps builds found for #1908. |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
@kcudnik, Please review the PR. this PR is needed for sairedis CI pipeline |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
No Azure DevOps builds found for #1908. |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
@GaladrielZhao, Can you please trigger CI pipeline? |
kcudnik
left a comment
kcudnik
left a comment
There was a problem hiding this comment.
how come suddenly this dependency is required ?
a7c6c90 to
9d8a4ed
Compare
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Hi @kcudnik , thanks for your review. We are implementing the RIB/FIB feature for SONiC. The libnexthopgroup library is a foundational component of this feature — it provides the encoding/decoding layer for NextHopGroup objects between FRR and fpmsyncd. You can find more details in RIB/FIB HLD. |
|
@kcudnik Also, could you help trigger the CI pipeline for this PR? We've tried reopening the PR and rebasing the commit, but neither worked. Thanks! |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
| runVersion: 'latestFromBranch' | ||
| runBranch: 'refs/heads/$(BUILD_BRANCH)' | ||
| path: $(Build.ArtifactStagingDirectory)/download | ||
| patterns: '**/target/debs/${{ parameters.debian_version }}/libnexthopgroup_*.deb' |
There was a problem hiding this comment.
This line breaks the pr checker:
/.azure-pipelines/build-docker-sonic-vs-template.yml (Line: 71, Col: 17): Key not found 'debian_version'
There was a problem hiding this comment.
Thanks for the feedback. Fixed — replaced ${{ parameters.debian_version }} with * since the template doesn't define that parameter.
sonic-swss PR #4394 added -lnexthopgroup to fpmsyncd link dependencies, but only updated swss's own CI pipeline. This causes sairedis CI to fail when compiling swss because libnexthopgroup is missing from the build environment. Add libnexthopgroup deb download and installation to: - build-swss-template.yml (swss compilation environment) - build-docker-sonic-vs-template.yml (VS image build) - docker-sonic-vs/Dockerfile (VS image runtime) Signed-off-by: Yuqing Zhao <galadriel.zyq@alibaba-inc.com>
a39ed25
9d8a4ed to
a39ed25
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @lolyu , the BuildTrixie arm64 job in this PR keeps failing with rsyslogd permission errors even after several reruns, which seem unrelated to my changes. Could you please help take a look? |
|
Need someone to check why it fails at here.
##[error]Bash exited with code '1'. @saiarcot895 can you help to check why Trixie build fails here. |
|
PR #1911 is to fix the build permission issue. |
Would they be in a dead lock situation? Neither PR would be able to pass the sanity now. Should we combine two PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this PR as it has been included in PR#1916 to avoid circular dependency. Thanks! |
6 participants
Description of PR
Summary:
sonic-swss PR #4394 added -lnexthopgroup to fpmsyncd link dependencies, but only updated swss's own CI pipeline. This causes sairedis CI to fail when compiling swss because libnexthopgroup is missing from the build environment, with the error message:
To fix this, let's add libnexthopgroup deb download and installation to:
Fix:
This PR will fix the CI building.
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?