CPO support in xcvrd HLD#2444
Draft
bgallagher-nexthop wants to merge 1 commit into
Draft
Conversation
bgallagher-nexthop
changed the title
xcvrd HLDxcvrd HLD
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
bgallagher-nexthop
force-pushed
the
xcvrd-cpo
branch
from
3dc844c to
401e0a8
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
bgallagher-nexthop
force-pushed
the
xcvrd-cpo
branch
from
401e0a8 to
1ffee06
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
bgallagher-nexthop
force-pushed
the
xcvrd-cpo
branch
from
1ffee06 to
32a0dc2
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
bgallagher-nexthop
force-pushed
the
xcvrd-cpo
branch
from
32a0dc2 to
7759dd9
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
tshalvi
reviewed
Jul 12, 2026
|
|
||
| ###### 7.2.2.2 Refactor of DomInfoUpdateTask Database Publishing Utilities | ||
|
|
||
| The `DomInfoUpdateTask` currently uses many utilities to collect information and publish it to the database. Many of these functions follow |
Contributor
There was a problem hiding this comment.
How are the DomInfoUpdateTask functions that do not follow the “read from EEPROM, then publish to DB” pattern expected to be handled by this refactoring? Could you also provide an example of such a function and explain how the proposed design would apply to it?
tshalvi
reviewed
Jul 12, 2026
| # self.cpo_obj_dict contains all CPO ports | ||
| cpo_manager = None | ||
| if self.cpo_obj_dict: | ||
| cpo_manager = CpoManagerTask(self.namespaces, port_mapping_data, self.cpo_obj_dict, self.stop_event) |
Contributor
There was a problem hiding this comment.
I think we should add a skip_cpo_mgr flag for CpoManagerTask, similar to the existing skip_cmis_mgr flag for CmisManagerTask. This would provide the option to delegate CPO module configuration to the firmware instead of handling it through xcvrd on platforms that support this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.