fix: prevent repeated select-all behavior in TimePickerSimple to allo…#1139
Open
ThieryPeleias wants to merge 1 commit into
Open
fix: prevent repeated select-all behavior in TimePickerSimple to allo…#1139ThieryPeleias wants to merge 1 commit into
ThieryPeleias wants to merge 1 commit into
Conversation
|
|
…w caret placement and partial text selection This resolves the issue where editing a time input selects the entire value on every click/pointer event, preventing single-digit edits. Ref: solidtime-io#1100
ThieryPeleias
force-pushed
the
fix/time-picker-caret-positioning
branch
from
5136f0a to
03c8aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR prevents the repeated select-all text behavior in the
TimePickerSimplecomponent. Currently,mouseup,click, andpointerupevent listeners force a full text selection on every pointer event. While editing was still possible via keyboard navigation, this made editing with the mouse extremely difficult as users could not position the caret or select custom text ranges with clicks.With this change:
Checklist (DO NOT REMOVE)