perf(coreNode): lazy-init _animations map#17
Merged
Conversation
Animations apply to a small fraction of nodes, so the empty object literal previously allocated in every CoreNode constructor was wasted GC pressure. Defer the allocation to the first animateProp() call; animateToTarget() and animateProp() handle the null case explicitly. Hot paths are unaffected — both call sites are app-triggered, not per-frame. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_animationswas an empty object literal allocated in everyCoreNodeconstructor, but only a small fraction of nodes ever animate. Defer the allocation to the firstanimateProp()call.animateProp()andanimateToTarget()now check fornullexplicitly. Both are app-triggered (not per-frame), so the added branch is free.Record<...> | nulland assigned throughthis._animations = {}on first use.Why
Reduces per-node GC pressure at construction. Considered a broader "lazy init everything until
isRenderable" pass but rejected it —localTransform/globalTransformare eager by design (see comment at CoreNode.ts:860) and underpin the translate-only fast paths from #13/#14, so making them optional would regress hot paths._animationsis the one field where lazy is a clean win with no hot-path cost.Test plan
pnpm buildpassespnpm test— 148/148 pass🤖 Generated with Claude Code