Skip to content

Added unique IDs to expander landmarks #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsha573252 wants to merge 1 commit into
base: release/v20.0.x
Choose a base branch
from
Open

Added unique IDs to expander landmarks #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/bits/e2e/components/expander/expander.a11y.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ test.describe("a11y: expander", () => {
const rulesToDisable: string[] = [
"aria-required-children",
"aria-dialog-name",
"landmark-unique",
"aria-command-name",
"nested-interactive",
];
Expand Down
2 changes: 1 addition & 1 deletion packages/bits/src/lib/expander/expander.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<div
class="nui-expander__body-wrapper"
role="region"
[attr.aria-label]="header || null"
[attr.aria-label]="header || ('Expander ' + uniqueId)"
>
<div
class="nui-expander__body"
Expand Down
7 changes: 6 additions & 1 deletion packages/bits/src/lib/expander/expander.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import {
import { expandV2 } from "../../animations/expand";
import { KEYBOARD_CODE } from "../../constants/keycode.constants";

let nextExpanderId = 0;

/**
* <example-url>./../examples/index.html#/expander</example-url>
*/
Expand Down Expand Up @@ -84,10 +86,13 @@ export class ExpanderComponent implements AfterContentInit {

public state: "expanded" | "collapsed" = "collapsed";
public isCustomHeaderContentEmpty: boolean = false;
public uniqueId: string;

private actionKeys = [KEYBOARD_CODE.SPACE, KEYBOARD_CODE.ENTER].map(String);

constructor(private cdRef: ChangeDetectorRef) {}
constructor(private cdRef: ChangeDetectorRef) {
this.uniqueId = String(++nextExpanderId);
}

public ngAfterContentInit(): void {
this.isCustomHeaderContentEmpty =
Expand Down