Skip to content

A11y fix from agent in main#857

Open
ludmilaFialova wants to merge 22 commits into
mainfrom
A11y_fix_from_agent_in_main
Open

A11y fix from agent in main#857
ludmilaFialova wants to merge 22 commits into
mainfrom
A11y_fix_from_agent_in_main

Conversation

@ludmilaFialova

Copy link
Copy Markdown
Contributor

Frontend Pull Request Description

https://swicloud.atlassian.net/browse/OO-62923
Using an agent to fix all accessibility issues in the Nova repository.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have updated change log
  • I have been following Definition of done
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new lint warnings
  • New and existing unit tests pass locally and on CI with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context (if necessary)

@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 2 times, most recently from 38647f8 to 577a1b2 Compare May 26, 2026 12:11
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 577a1b2 to 9e22c8e Compare May 27, 2026 10:20

&-remove {
cursor: pointer;
display: inline-flex;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no regression? or it is bug fix?

@ludmilaFialova ludmilaFialova May 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to fix the position of the icon after inserting it into <span> in chip.component.html

pavlo-poimanov
pavlo-poimanov previously approved these changes May 27, 2026

@pavlo-poimanov pavlo-poimanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 2 times, most recently from 689d3b8 to 8264923 Compare May 28, 2026 20:23
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 2 times, most recently from 8cde0eb to 276bdad Compare May 29, 2026 07:08
@ludmilaFialova ludmilaFialova marked this pull request as draft June 4, 2026 17:21
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 276bdad to 7985370 Compare June 5, 2026 15:34
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 7985370 to 1557138 Compare June 8, 2026 10:44
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 3 times, most recently from 72b68b9 to 31a505e Compare June 8, 2026 15:37
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from d38a32e to 2d57188 Compare June 9, 2026 11:51
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 2 times, most recently from b830034 to cfa1d84 Compare June 12, 2026 10:35
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from cfa1d84 to 6138d55 Compare June 12, 2026 12:16
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 2 times, most recently from 90d1f7e to 7a61333 Compare June 15, 2026 09:51
@ludmilaFialova ludmilaFialova marked this pull request as ready for review June 15, 2026 09:55
@ludmilaFialova ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 7a61333 to 35ca2bb Compare June 15, 2026 11:36
@ludmilaFialova ludmilaFialova requested a review from erzik987 June 19, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants