Skip to content

Fix package id source to std for builtin plugins if they're patched. - #3174

Closed
Arcticae wants to merge 1 commit into
mainfrom
fix/builtin-plugin-patched-source
Closed

Fix package id source to std for builtin plugins if they're patched.#3174
Arcticae wants to merge 1 commit into
mainfrom
fix/builtin-plugin-patched-source

Conversation

@Arcticae

Copy link
Copy Markdown
Member

We couldn't compile the tests because scarb tried to load those plugins from registry instead of local setup (which didn't exist on the registry since they're builtin plugins). Now the source is set to std as intended

https://docs.swmansion.com/maat/release-2.20.0-rc.0-0.62.1/starkware-libs/starknet-perpetual-fce7c194f/logs.txt

[out] error: compiler plugin could not be loaded `starknet v2.20.0-rc.0`
[out] 
[out] Stack backtrace:
[out]    0: <anyhow::Error>::msg::<alloc::string::String>
[out]    1: anyhow::__private::format_err
[out]    2: <scarb::compiler::plugin::collection::PluginsForComponents>::collect
[out]    3: scarb::compiler::db::build_scarb_root_database
[out]    4: scarb::ops::compile::compile_cairo_unit_inner
[out]    5: std::sys::backtrace::__rust_begin_short_backtrace::<scarb::ops::compile::compile_unit::{closure#0}::{closure#0}, core::result::Result<(), anyhow::Error>>
[out]    6: <std::thread::lifecycle::spawn_unchecked<scarb::ops::compile::compile_unit::{closure#0}::{closure#0}, core::result::Result<(), anyhow::Error>>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
[out]    7: <std::sys::thread::unix::Thread>::new::thread_start
[out]    8: start_thread
[out]    9: __clone
[out] error: could not compile `fulfillment` due to 1 previous error and 16 warnings
[out] 
[out] Stack backtrace:
[out]    0: <anyhow::Error>::msg::<alloc::string::String>
[out]    1: std::sys::backtrace::__rust_begin_short_backtrace::<scarb::ops::compile::compile_unit::{closure#0}::{closure#0}, core::result::Result<(), anyhow::Error>>
[out]    2: <std::thread::lifecycle::spawn_unchecked<scarb::ops::compile::compile_unit::{closure#0}::{closure#0}, core::result::Result<(), anyhow::Error>>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
[out]    3: <std::sys::thread::unix::Thread>::new::thread_start
[out]    4: start_thread
[out]    5: __clone
Process finished with exit code 1```

@Arcticae
Arcticae requested a review from a team as a code owner July 14, 2026 09:51
@Arcticae
Arcticae requested review from integraledelebesgue, maciektr, piotmag769 and wawel37 and removed request for a team, integraledelebesgue and wawel37 July 14, 2026 09:51

@maciektr maciektr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arcticae how about something like this? #3178

@maciektr

Copy link
Copy Markdown
Contributor

Closing as replaced with #3178

@maciektr maciektr closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants