Skip to content

chore: reduce flakiness for test api equivalence spec #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterSchafer merged 1 commit into from
Jun 29, 2026
Merged

chore: reduce flakiness for test api equivalence spec #6955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions test/jest/acceptance/snyk-test/unified-test-api-equivalence.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,34 @@
* Starter corpus. Expand per resolveDepgraphs-rollout-plan.md.
*/

import { fakeServer } from '../../../acceptance/fake-server';
import {
fakeServer,
getFirstIPv4Address,
} from '../../../acceptance/fake-server';
import { createProjectFromWorkspace } from '../../util/createProject';
import { getServerPort } from '../../util/getServerPort';
import { getAvailableServerPort } from '../../util/getServerPort';
import { assertEquivalent, runBothFlows } from './equivalenceHelpers';

jest.setTimeout(1000 * 60 * 3);
jest.setTimeout(1000 * 60 * 5);

describe('snyk test — unified test API equivalence (FF off vs on)', () => {
let server;
let env: Record<string, string>;

beforeAll((done) => {
const port = getServerPort(process);
beforeAll(async () => {
const port = await getAvailableServerPort(process);
const baseApi = '/v1';
const fakeServerIp = getFirstIPv4Address();
env = {
...process.env,
SNYK_API: 'http://localhost:' + port + baseApi,
SNYK_HOST: 'http://localhost:' + port,
SNYK_API: `http://${fakeServerIp}:${port}${baseApi}`,

@PeterSchafer PeterSchafer Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there any explanation why this change has an effect on flakiness?

@PeterSchafer PeterSchafer Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it is the right move to use this pattern but for other reasons then flakiness in my understanding.

@danskmt danskmt Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems he's applying the pattern in other tests, so sounds correct.
For the flakiness, it might be the timeout increase to fix it:
Image

@robertolopezlopez robertolopezlopez Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was writing a comment here, it turned to be the same as this

For the flakiness, it might be the timeout increase to fix it

@PeterSchafer PeterSchafer Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I added the timeout ;)

SNYK_HOST: `http://${fakeServerIp}:${port}`,
SNYK_TOKEN: '123456789',
SNYK_DISABLE_ANALYTICS: '1',
SNYK_HTTP_PROTOCOL_UPGRADE: '0',
};
server = fakeServer(baseApi, env.SNYK_TOKEN);
server.listen(port, () => done());
await server.listenPromise(port);
});

afterAll((done) => {
Expand Down