Skip to content

fix: use Minitest.after_run for report summary #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pftg merged 7 commits into from
Apr 12, 2026
Merged

fix: use Minitest.after_run for report summary #182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b2dd1a8
fix: use Minitest.after_run for report summary, not at_exit
pftg Apr 12, 2026
2bb7b97
fix: keep base image when screenshots differ for reporter
pftg Apr 12, 2026
008a9c7
docs: document .gitignore patterns for diff artifacts
pftg Apr 12, 2026
9e7566d
fix: register both at_exit and Minitest.after_run hooks
pftg Apr 12, 2026
a8eb40f
refactor: avoid double finalize call for Minitest
pftg Apr 12, 2026
3eda7fa
fix: register framework-native hooks for RSpec and Cucumber
pftg Apr 12, 2026
797008f
refactor: move finalize_reporters! to framework adapters
pftg Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/capybara_screenshot_diff/reporters/html.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def write_report
CapybaraScreenshotDiff.reporters << CapybaraScreenshotDiff::Reporters::HTML.new(embed_images: !!ENV["CI"])
end

at_exit do
snap_diff_finalize = proc do
CapybaraScreenshotDiff.reporters_mutex.synchronize { CapybaraScreenshotDiff.reporters.dup }.each do |reporter|
reporter.finalize
if (msg = reporter.summary)
Expand All @@ -146,3 +146,9 @@ def write_report
warn "[snap_diff] Reporter #{reporter.class} failed (#{e.class}: #{e.message})"
end
end

if defined?(Minitest) && Minitest.respond_to?(:after_run)
Minitest.after_run(&snap_diff_finalize)
else
at_exit(&snap_diff_finalize)
end
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
2 changes: 0 additions & 2 deletions lib/capybara_screenshot_diff/screenshot_assertion.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ def self.verify_screenshots!(screenshots)
test_screenshot_errors.compact!

test_screenshot_errors.empty? ? nil : test_screenshot_errors
ensure
screenshots&.clear
end

# Asserts that an image has not changed compared to its baseline.
Expand Down
Loading