fix(mcp): resolve npm CLI shims on Windows for claude-code installs#790
Open
syf2211 wants to merge 1 commit into
Open
fix(mcp): resolve npm CLI shims on Windows for claude-code installs#790syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
- Use claude.cmd/gemini.cmd/codex.cmd on win32 so execFileSync can find npm global shims when installing MCP servers via --client - Improve missing-CLI errors to reference the client label instead of only the raw command name Fixes smithery-ai#781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix misleading
Command 'claude' not founderrors when runningsmithery mcp add <server> --client claude-codeon Windows.Motivation
On Windows, npm global CLIs (including Claude Code) are exposed as
.cmdshims.execFileSyncdoes not applyPATHEXT, so invokingclaudefails even whenclaude.cmdis on PATH. Users interpreted this as an invalid--clientvalue.Fixes #781
Fixes #794
Changes
resolveNpmCliCommand()helper to append.cmdon win32claude-code,gemini-cli,codexTests
pnpm test— 400 passedpnpm run check— passedpnpm run typecheck— passedNotes
code.cmdpattern already used in this repo