series of changes to datasets API documentation - #2236
Conversation
|
Looking good! It seems the tests fail because loading a dataset involves printing progress, which leads to unexpected outputs. For instance, the last test that does this expects no output but has The two ways this can be avoided are either to actually put this expected output in the example or bypass API testing entirely for these docstrings. The former will make the docstring a bit unwieldy, and require maintenance if the format of this output ever changes, so I'd lean towards the latter (besides, I think these specific examples can do without strict verification). |
Good catch @emassoulie. I agree that the latter solution is probably the better one. Doctests here are not too important because the test suite is explicitly testing the same things elsewhere. |
|
At a second glance, I think the doctests for single tables that only print the shape can be removed: that information is already present in the docstring. However, for datasets that include multiple tables I think it's useful to have the keys of the bunch so that users can easily figure out what datasets they are working with. |
Updated the documentation for the datasets available to download.
Changes consist of:
fetch_electricity_forecastingdocstring to a See Also