Fix a 'Pre-transform error' using aliases with Vite#8
Merged
skirtles-code merged 1 commit intomainfrom May 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem reported in #7.
When using
@aliases withshadcn-vue, there's an error trying to run the playground and docs packages:The relevant code is:
The problem isn't unique to
shadcn-vue, the same thing would happen for other uses of@aliases that don't resolve exactly to a file. For example, any imports that don't include the extension, or that rely on resolving to anindexfile.The solution implemented here is to pass the new path through
this.resolve(), after the@has been replaced. This will apply the other resolution rules required to handle those cases.These changes should allow Vite to resolve the aliases correctly, both during dev and for a production build.
There is a related problem with the
type-checkcommand. This is still failing to resolve the aliases correctly in the playground and docs packages.