add swapAndLombardTransfer - #27
Open
thal0x wants to merge 3 commits into
Open
Conversation
thal0x
marked this pull request as ready for review
April 11, 2025 15:21
mattac21
approved these changes
Apr 16, 2025
| IERC20(lbtc).safeTransfer(fees.relayFeeRecipient, fees.relayFee); | ||
| } | ||
|
|
||
| uint256 amountOutAfterFees = amountOut - _totalFees(fees); |
There was a problem hiding this comment.
why do we deduct the relay fee from the amount out here, when during the lombardTransfer function collect the fee but don't actually subtract it from the input amount. I'm assuming its some difference between lombardTransfer using safeTransferFrom(msg.sender, ...) and the swapAndLombardTransfer using safeTransfer to send the relay fee to the recipient, but not completely sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
swapAndLombardTransferto theEurekaHandlercontract.The flow:
amountIn - feeto iLBTCv