SetParameterType: compatible with break change about in typescript 5.4

[Emiyaaaaa]

1. Compatible with break change about the rest index in array in typescript 5.4

2. Replace npm test with npx tsc in github workflow to make testing more comprehensive

related #831

[voxpelli]

This makes it test more than just typescript and may fail for unrelated reasons

[Emiyaaaaa]

How about using npm test in ts-canary.yml?

[voxpelli]

As was mentioned in the issue, tsd ships with its own copy of typescript and as such isn't affected by any changes to the typescript dependency: #831 (comment)

One would instead have to do what I believe @shicks and @trevorade are doing: Use eg. expect-type instead: #499

And since expect-type is validated as part of running tsc itself, no changes to the GitHub Actions would be done then either.

That said: Replacing tsd with expect-type is a much broader topic, as highlighted by eg #499

Though: Since expect-type is already a dev dependency of type-fest as far as I remember it could be good to add a test using that and ensure that breaks the canary tests correctly, at least that way we won't see a regression again.

[voxpelli]

See

type-fest/test-d/get.ts

Line 1 in 4f14bff

import {expectTypeOf} from 'expect-type';

and

type-fest/test-d/required-deep.ts

Line 2 in 4f14bff

import {expectTypeOf} from 'expect-type';

Though I'm a bit uncertain if those are actually run using tsc rather than tsd

[Emiyaaaaa]

Got it

[Emiyaaaaa]

Though I'm a bit uncertain if those are actually run using tsc rather than tsd

Unfortunately it's using tsd.

Directory test-d/ was excluded in tsconfig. https://github.com/sindresorhus/type-fest/blob/4f14bff7321b9a9876dca0719945423abd6b4da1/tsconfig.json#L14C2-L14C16