Skip to content

kubernetes module: catch TimeoutError and raise VelaKubernetesError #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boddumanohar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

kubernetes module: catch TimeoutError and raise VelaKubernetesError #550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ee427
catch log TimeoutError in branch list api
boddumanohar Jan 30, 2026
530e59c
move TimeoutError to kubernetes module and raise VelaKubernetesError
boddumanohar Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/deployment/kubernetes/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import logging
from contextlib import asynccontextmanager

from aiohttp import ClientTimeout
from aiohttp import ClientError, ClientTimeout
from kubernetes_asyncio.client import ApiClient, CoreV1Api, CustomObjectsApi, DiscoveryV1Api, StorageV1Api
from kubernetes_asyncio.config import load_incluster_config, load_kube_config
from kubernetes_asyncio.config.config_exception import ConfigException

from ...exceptions import VelaKubernetesError

KUBE_API_SERVER_TIMEOUT = 10
logger = logging.getLogger(__name__)


class ApiClientWithTimeout(ApiClient):
Expand All @@ -20,7 +22,14 @@ async def call_api(self, *args, _request_timeout=None, **kwargs):
_request_timeout = self.default_timeout
if "_request_timeout" not in kwargs:
kwargs["_request_timeout"] = _request_timeout
return await super().call_api(*args, **kwargs)
try:
return await super().call_api(*args, **kwargs)
except TimeoutError as exc:
logger.error("Kubernetes API request timed out (timeout=%ss)", _request_timeout, exc_info=exc)
raise VelaKubernetesError("Kubernetes API request timed out") from exc
except ClientError as exc:
logger.error("Kubernetes API request failed with client error", exc_info=exc)
raise VelaKubernetesError("Kubernetes API client error") from exc


async def _ensure_kubeconfig() -> None:
Expand Down