Skip to content

Make it possible to resize window#6

Open
stianval wants to merge 1 commit into
simenheg:sdl2from
stianval:sdl2
Open

Make it possible to resize window#6
stianval wants to merge 1 commit into
simenheg:sdl2from
stianval:sdl2

Conversation

@stianval

Copy link
Copy Markdown

Another feature for parity with SDL1 version

Issue #3

Another feature for parity with SDL1 version

Issue simenheg#3
@simenheg

simenheg commented Jan 4, 2025

Copy link
Copy Markdown
Owner

Great stuff @stianval, resizing now seems to work like in the SDL1 version! Thanks. :)

However this seems to introduce some new problems with the fullscreen mode:

  • When maximizing the screen and then going into fullscreen mode, the screen seems to be cropped/overflow at the bottom (this is easiest to see with the "show border" option turned on.
  • The screen turns black sometimes when in fullscreen mode, sometimes also immediately when entering the game. The menu and sounds still work, but nothing is rendered.

@stianval

Copy link
Copy Markdown
Author

Happy new year @simenheg!

Confirming I can reproduce the problem when maximizing the window and then going to fullscreen. The reason is not entirely clear, so I may have to spend some time on it.

The screen turns black sometimes when in fullscreen mode, sometimes also immediately when entering the game. The menu and sounds still work, but nothing is rendered.

Is this also only after maximizing the screen and then going to fullscreen, or does this happen other times as well?

@simenheg

Copy link
Copy Markdown
Owner

Hey @stianval, sorry for replying so late.

The screen turns black sometimes when in fullscreen mode, sometimes also immediately when entering the game. The menu and sounds still work, but nothing is rendered.

Is this also only after maximizing the screen and then going to fullscreen, or does this happen other times as well?

The screen doesn't need to be maximized for it to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants