ci: modernize workflows (fix failing Linux build & BrowserStack) - #1052
Merged
Conversation
…rted Node) The Linux build and BrowserStack jobs were failing at setup, before any test ran: - 'npm install -g npm' ran against the runner's system Node and failed with EACCES (mkdir /usr/local/share/man/man7). Removed the step; setup-node already provides a current npm. - actions/checkout@v2 and actions/setup-node@v2 are deprecated and the v2 cache backend started returning 'Cache service responded with 400'. Bumped both to @v4. - The Node matrix targeted EOL releases (12/14/16/17). Moved to the currently supported lines (18/20/22); the project already builds and tests cleanly on modern Node.
BrowserStack rejects these stale configs: Can not start safari (ios 11.0): Validation Failed - os_version invalid Can not start chrome (android 4.4): Validation Failed - device invalid Remove the bstack_iphoneX and bstack_android launchers (and their entries in the browsers list) so the BrowserStack job can run.
- codeql-action init/autobuild/analyze v1 -> v3 (the v1 actions run on EOL Node 12 and are being removed by GitHub). - actions/checkout v2 -> v4 (CodeQL) and v3 -> v4 (docs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Node Linux CIandBrowserStackjobs have been failing at the setup stage, before any test runs:🚚 Upgrade NPM(npm install -g npm) runs against the runner's system Node and fails withEACCES: permission denied, mkdir '/usr/local/share/man/man7'.actions/checkout@v2/actions/setup-node@v2are deprecated; the v2 cache backend returnsCache service responded with 400(seen onbuild (16.x)).safari ios 11.0,chrome android 4.4).@v1actions (EOL Node 12).Fix
Upgrade NPMstep (Linux + BrowserStack) —setup-nodealready ships a current npm.checkout/setup-nodeto@v4across Linux, Windows, BrowserStack, CodeQL and docs workflows;codeql-action/*@v1->@v3.18.x, 20.x, 22.x.