fix: show glob-specific error for path separators in --glob patterns (fixes #1720)#2017
Open
wyf027 wants to merge 1 commit into
Open
fix: show glob-specific error for path separators in --glob patterns (fixes #1720)#2017wyf027 wants to merge 1 commit into
wyf027 wants to merge 1 commit into
Conversation
When --glob is used with a pattern containing '/', show guidance to use --glob --full-path instead of the generic regex-oriented diagnostic. Fixes sharkdp#1720 Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--globis used with a pattern containing/, show a glob-specific error message--glob --full-pathfor matching against full pathsMotivation
Fixes #1720. The existing path-separator diagnostic is regex-oriented; glob users benefit from guidance that mentions
--glob --full-pathexplicitly.Example
Test plan
cargo test test_glob_pattern_with_forward_slash_is_rejected