fix: hint shell builtins in command-not-found error#2014
Open
wyf027 wants to merge 1 commit into
Open
Conversation
When -x/-X fails because the program is a shell builtin (e.g. cd), include a short note and an example of invoking a shell explicitly. Fixes sharkdp#1944
wyf027
force-pushed
the
fix/shell-builtin-hint-1944-v2
branch
from
4722a38 to
ecd8a7e
Compare
Collaborator
|
There's already an open pr for this |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-x/-Xfails with "command not found" for a known shell builtin (e.g.cd), append a hint that builtins must be run through a shellFixes #1944
Test plan
cargo test exec::commandcargo clippy -- -D warningsfd -t d -x cdshows the new hint message