fix: hint shell builtins in command-not-found error (fixes #1944)#2005
Closed
wyf027 wants to merge 3 commits into
Closed
fix: hint shell builtins in command-not-found error (fixes #1944)#2005wyf027 wants to merge 3 commits into
wyf027 wants to merge 3 commits into
Conversation
When a user runs `fd -x cd` or similar shell builtins that lack standalone executables, the "Command not found" error now explains that the command is a shell builtin and suggests invoking it through a shell explicitly.
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 16, 2026
Contributor
Author
ded-furby
suggested changes
Jun 1, 2026
ded-furby
left a comment
ded-furby
left a comment
There was a problem hiding this comment.
Thanks for getting a green version of this fix up. There is one cross-platform problem to address before merge: the new hint hardcodes sh -c, which is Unix-specific. fd supports Windows targets in CI, and on those builds the suggested command is likely to fail with another command-not-found error. I think this should either use a platform-neutral hint or switch examples per platform.
| format!( | ||
| "Command not found: {program}. Note: {program} is a shell builtin, \ | ||
| not a standalone program. To run shell builtins, invoke a shell explicitly, \ | ||
| e.g. fd -x sh -c '{program} ... \"$1\"' sh {{}}", |
There was a problem hiding this comment.
This example is Unix-specific. On Windows, suggesting sh -c will usually fail, so the new diagnostic replaces one confusing error with another. Could we make the hint platform-neutral here, or choose the example based on the target shell/OS instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1944 with the same approach as #1994 by @kimjune01, plus a one-line clippy fix (
SHELL_BUILTINS.contains(&program)).Note on #1994
#1994 has the same feature but CI fails on
clippy::manual_contains. I’m happy to close this PR if #1994 is updated — opening this only so maintainers have a green CI option.Testing
cargo test builtin_testscargo clippy -- -D warnings