Initial attempt at adding support for pcre#1606
Draft
tmccombs wants to merge 1 commit into
Draft
Conversation
tmccombs
force-pushed
the
pcre
branch
2 times, most recently
from
285e236 to
8de8940
Compare
This also significantly refactors the code for creating the regexes to match with, and in some cases avoids using regex altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also significantly refactors the code for creating the regexes to match with, and in some cases avoids using regex altogether.
Fixes #1603 #399
I'm not sure if this is worth doing, but wanted to see what it would take.