[Bug Fix]Fix m_indices argument passing in BF16 grouped contiguous warmup - #27002
Closed
laurxh wants to merge 1 commit into
Closed
[Bug Fix]Fix m_indices argument passing in BF16 grouped contiguous warmup#27002laurxh wants to merge 1 commit into
laurxh wants to merge 1 commit into
Conversation
The deep_gemm API changed m_indices from a keyword argument to a positional argument. Pass it positionally to avoid TypeError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
laurxh
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock and
merrymercy
as code owners
June 2, 2026 03:15
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
laurxh
marked this pull request as draft
June 2, 2026 05:18
laurxh
marked this pull request as ready for review
June 2, 2026 05:58
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
laurxh
force-pushed
the
fix/deep-gemm-warmup
branch
from
June 2, 2026 07:47
dd35da1 to
cf0b822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepGEMM >= 2.5.0 (PR deepseek-ai/DeepGEMM#280) renamed the 4th parameter of
m_grouped_bf16_gemm_nt_contiguousfromm_indicestogrouped_layout.The BF16 grouped contiguous warmup executor in SGLang uses keyword argument
m_indices=, which causes a TypeError on startup:Reproduce:
Modifications
Changed m_indices=self.m_indices[:m] (keyword) to self.m_indices[:m] (positional)
in _BF16GroupedContWarmupExecutor.execute() to match the DeepGEMM pybind11 API.
The parameter functionality is unchanged — it is still an int32 tensor indicating which
expert group each row belongs to. Only the parameter name was changed upstream.
Checklist
CI States
Latest PR Test (Base): ❌ Run #26806013714
Latest PR Test (Extra): ❌ Run #26806013517