Fix integrate-mysql CI: backtick-quote SQL columns, skip Pro-only workflow dredd tests#3965
Draft
Copilot wants to merge 2 commits into
Draft
Fix integrate-mysql CI: backtick-quote SQL columns, skip Pro-only workflow dredd tests#3965Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…dredd tests - db/sql/SqlDb.go: backtick-quote column names in InsertTemplateFromType to avoid MySQL reserved-keyword errors (e.g. `condition` in WorkflowEdge) - .dredd/hooks/helpers.go: preserve input nodes in addWorkflow() return value when the workflow stub returns an empty struct, preventing a panic in addWorkflowApproval() - .dredd/hooks/main.go: skip all 11 workflow transactions in dredd hooks; workflow is a Pro-only feature that cannot be exercised from the OSS hook binary
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job integrate-mysql
Fix integrate-mysql CI: backtick-quote SQL columns, skip Pro-only workflow dredd tests
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workflows PR introduced dredd hooks for a Pro-only feature backed by an OSS no-op stub, causing the
integrate-mysqlCI job to fail with a MySQL syntax error, then a hooks process panic that took down all subsequent transactions.Changes
db/sql/SqlDb.go— Backtick-quote all column names inInsertTemplateFromType.WorkflowEdge.Conditionmaps tocondition, a reserved keyword in MySQL 8.x, producing:Backticks are already transparently converted to double-quotes for PostgreSQL by the existing
PrepareQuerypath. This also proactively coverslimit(WorkflowNode) and any future reserved-keyword columns..dredd/hooks/helpers.go— InaddWorkflow(), fall back to input nodes when the store returns an empty struct (OSS stub).addWorkflowApproval()panics ifworkflow.Nodesis nil; that panic kills the hooks process and cascades every subsequent dredd transaction to fail..dredd/hooks/main.go— Add all 11 workflow transactions toskipTests. The OSS hook binary uses the stub, soworkflowIDis always0and every workflow endpoint returns 404 against the real Pro binary. Workflow endpoints are covered by the Pro integration suite.