Feat/UI notification improvements#3936
Open
thefu21 wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated Notification Management system within the Project Settings UI and backend API. Currently, notification configurations in Semaphore are rigid and historically constrained. This change implements a clean, multi-service architecture per project, initially focusing on Email alerts. It provides an easily extendable foundation for adding more notification providers in future standalone updates.
What was done:
db/):2.18.8containing tables for customproject__notificationprofiles and their respective connections to template alerts (project__template_notification).NotificationManagermethods (Create,Get,Update,Delete, andGetRefs).NotificationMiddlewarefor parameter extraction and contextual validation.Create,Update,Delete) into the project's internalEventLogwith typedb.EventNotification.sendTemplateNotifications()into the core task runner logging loop (TaskRunner_logging.go) to dynamically trigger active alerting when tasks succeed, fail, or stop.AccessKeymanager) to pull encrypted username/password values seamlessly.router.goto securely parse and update user notification policies per individual project scope.Future Extensibility
Impact
Improves user experience significantly by making alerting granularly adjustable across distinct automated playbooks.
Related / Fixes
Addresses parts of the long-standing community request regarding modular alerting structures.
Fixes #3387