-
Notifications
You must be signed in to change notification settings - Fork 313
[ms-bing-ads-audiences] Add temporary debug logging of API responses #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harsh-joshi99
wants to merge
10
commits into
main
Choose a base branch
from
debug/ms-bing-ads-audiences-response-logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+763
−7
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c0e7d8c
[ms-bing-ads-audiences] Add temporary debug logging of API responses
harsh-joshi99 9ac9829
[ms-bing-ads-audiences] Address Copilot review feedback
harsh-joshi99 8f2b03f
[ms-bing-ads-audiences] Log response.content instead of response.data
harsh-joshi99 f08f4a9
[ms-bing-ads-audiences] Correct debug-logging header comment
harsh-joshi99 96f770f
[ms-bing-ads-audiences] Include request metadata in error debug log
harsh-joshi99 3f16536
[ms-bing-ads-audiences] Harden debug logging (review feedback)
harsh-joshi99 4b77498
[ms-bing-ads-audiences] Log Microsoft tracking id
harsh-joshi99 d153c1b
[ms-bing-ads-audiences] Sanitize audienceId; make truncation cap strict
harsh-joshi99 41a1d33
[ms-bing-ads-audiences] Never truncate the tracking id
harsh-joshi99 aa5b94b
[ms-bing-ads-audiences] Only log successful responses; drop error log…
harsh-joshi99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
342 changes: 342 additions & 0 deletions
342
packages/destination-actions/src/destinations/ms-bing-ads-audiences/metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,342 @@ | ||
| { | ||
| "slug": "actions-ms-bing-ads-audiences", | ||
| "name": "Ms Bing Ads Audiences", | ||
| "mode": "cloud", | ||
| "authentication": { | ||
| "scheme": "oauth2", | ||
| "fields": { | ||
| "customerAccountId": { | ||
| "label": "Customer Account ID", | ||
| "description": "The account ID of the Microsoft Advertising account you want to manage. You can find it in the URL when viewing the account in the Microsoft Ads User Interface. Not to be confused with Account Number.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "choices": null, | ||
| "default": null, | ||
| "depends_on": null | ||
| }, | ||
| "customerId": { | ||
| "label": "Customer ID", | ||
| "description": "The customer (parent) ID associated with your Microsoft Advertising account. You can find this in the URL when viewing your account in the Microsoft Ads User Interface.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "choices": null, | ||
| "default": null, | ||
| "depends_on": null | ||
| } | ||
| } | ||
| }, | ||
| "audienceConfig": { | ||
| "mode": { | ||
| "type": "synced", | ||
| "full_audience_sync": false | ||
| }, | ||
| "audienceFields": {}, | ||
| "supportsAudienceFunctions": true | ||
| }, | ||
| "actions": { | ||
| "syncAudiences": { | ||
| "title": "Sync Audiences", | ||
| "description": "Sync users to Microsoft Bing Ads Audiences", | ||
| "platform": "cloud", | ||
| "defaultSubscription": null, | ||
| "hidden": false, | ||
| "hasPerformBatch": true, | ||
| "syncMode": null, | ||
| "hooks": null, | ||
| "dynamicFields": null, | ||
| "fields": { | ||
| "audience_id": { | ||
| "label": "Audience ID", | ||
| "description": "The ID of the audience to which you want to add or remove users.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@path": "$.context.personas.external_audience_id" | ||
| }, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": true, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "traits_or_props": { | ||
| "label": "[Hidden] Traits or Properties", | ||
| "description": "[Hidden] properties object from track() payloads. Note: identify calls are not handled and are disabled in the Partner Portal.", | ||
| "type": "object", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@path": "$.properties" | ||
| }, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": true, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "audience_key": { | ||
| "label": "[Hidden] Audience Key", | ||
| "description": "[Hidden]: The Engage Audience Key / Slug.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@path": "$.context.personas.computation_key" | ||
| }, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": true, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "identifier_type": { | ||
| "label": "Identifier Type", | ||
| "description": "The type of identifier you are using to sync users.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": "Email", | ||
| "choices": [ | ||
| { | ||
| "label": "Email", | ||
| "value": "Email" | ||
| }, | ||
| { | ||
| "label": "CRM ID", | ||
| "value": "CRM" | ||
| } | ||
| ], | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": null, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "email": { | ||
| "label": "Email", | ||
| "description": "The email address of the user to add or remove from the audience.", | ||
| "type": "string", | ||
| "required": { | ||
| "conditions": [ | ||
| { | ||
| "fieldKey": "identifier_type", | ||
| "operator": "is", | ||
| "value": "Email" | ||
| } | ||
| ] | ||
| }, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@if": { | ||
| "exists": { | ||
| "@path": "$.context.traits.email" | ||
| }, | ||
| "then": { | ||
| "@path": "$.context.traits.email" | ||
| }, | ||
| "else": { | ||
| "@path": "$.properties.email" | ||
| } | ||
| } | ||
| }, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": "hashedPII", | ||
| "depends_on": { | ||
| "conditions": [ | ||
| { | ||
| "fieldKey": "identifier_type", | ||
| "operator": "is", | ||
| "value": "Email" | ||
| } | ||
| ] | ||
| }, | ||
| "readOnly": null, | ||
| "hidden": null, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "crm_id": { | ||
| "label": "CRM ID", | ||
| "description": "The CRM ID of the user to add or remove from the audience.", | ||
| "type": "string", | ||
| "required": { | ||
| "conditions": [ | ||
| { | ||
| "fieldKey": "identifier_type", | ||
| "operator": "is", | ||
| "value": "CRM" | ||
| } | ||
| ] | ||
| }, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@path": "$.userId" | ||
| }, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": { | ||
| "conditions": [ | ||
| { | ||
| "fieldKey": "identifier_type", | ||
| "operator": "is", | ||
| "value": "CRM" | ||
| } | ||
| ] | ||
| }, | ||
| "readOnly": null, | ||
| "hidden": null, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "enable_batching": { | ||
| "label": "Enable Batching", | ||
| "description": "Enable batching of user syncs to optimize performance. When enabled, user syncs will be sent in batches based on the specified batch size.", | ||
| "type": "boolean", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": true, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": true, | ||
| "hidden": null, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "batch_size": { | ||
| "label": "[Hidden] Batch Size", | ||
| "description": "[Hidden] The number of user syncs to include in each batch when batching is enabled. Must be between 1 and 1000.", | ||
| "type": "number", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": 1000, | ||
| "choices": null, | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": true, | ||
| "minimum": 1, | ||
| "maximum": 1000, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| }, | ||
| "computation_class": { | ||
| "label": "Computation Class", | ||
| "description": "Hidden field: The computation class for the audience.", | ||
| "type": "string", | ||
| "required": true, | ||
| "multiple": false, | ||
| "allowNull": false, | ||
| "dynamic": false, | ||
| "default": { | ||
| "@path": "$.context.personas.computation_class" | ||
| }, | ||
| "choices": [ | ||
| { | ||
| "label": "audience", | ||
| "value": "audience" | ||
| }, | ||
| { | ||
| "label": "journey_step", | ||
| "value": "journey_step" | ||
| } | ||
| ], | ||
| "placeholder": null, | ||
| "properties": null, | ||
| "category": null, | ||
| "depends_on": null, | ||
| "readOnly": null, | ||
| "hidden": true, | ||
| "minimum": null, | ||
| "maximum": null, | ||
| "defaultObjectUI": null, | ||
| "disabledInputMethods": null, | ||
| "displayMode": null, | ||
| "format": null, | ||
| "additionalProperties": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "presets": [] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.