Skip to content

[Facebook Custom Audiences] - correct error type#3832

Open
joe-ayoub-segment wants to merge 1 commit into
mainfrom
correct-fb-custom-audience-test-type
Open

[Facebook Custom Audiences] - correct error type#3832
joe-ayoub-segment wants to merge 1 commit into
mainfrom
correct-fb-custom-audience-test-type

Conversation

@joe-ayoub-segment

Copy link
Copy Markdown
Contributor

Main build broken as error type incorrect in fbca destination - causing unit tests to fail.

Testing

None required.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

Copilot AI review requested due to automatic review settings June 15, 2026 17:25
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner June 15, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the error code returned by the Facebook Custom Audiences sync implementation when early validation fails, aligning runtime behavior with the destination’s expected MultiStatus error typing and unblocking failing unit tests.

Changes:

  • Update the validation failure path in send() to return ErrorCodes.INVALID_AUDIENCE_MEMBERSHIP instead of ErrorCodes.PAYLOAD_VALIDATION_FAILED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants