Fix isLCS repeated expression and refactor it with base functions - #39
Merged
Conversation
ninioArtillero
changed the title
isLCS conjunction in testsisLCS and use standard library's subsequence functions
ninioArtillero
changed the title
isLCS and use standard library's subsequence functionsisLCS and refactor with base subsequence functions
ninioArtillero
force-pushed
the
xg/fix-islcs
branch
from
August 12, 2026 17:34
5288537 to
2e73396
Compare
ninioArtillero
force-pushed
the
xg/fix-islcs
branch
from
August 12, 2026 17:38
2e73396 to
20fe01b
Compare
ninioArtillero
changed the title
isLCS and refactor with base subsequence functionsisLCS repeated expression and refactor it with base functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opening expressions in
isLCSconjunction were (evidently) intended to checkssis a subsequence of bothxsandys, but it was only checked for the latter. This PR fixes this.Also, the "quick and dirty" subsequence functions are replaced with those from
Data.List, making the associatedtestGroupfor their correct implementation unnecessary.