Skip to content

Fix NETLOGON_LOGON_QUERY parsing: Add mailslot name alignment #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixEditor wants to merge 6 commits into
base: master
Choose a base branch
from
+81 −9
Open

Fix NETLOGON_LOGON_QUERY parsing: Add mailslot name alignment #4952

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c0df1c
fix NETLOGON_LOGON_QUERY: add mailslot name alignment
MatrixEditor Mar 22, 2026
c8c3a4b
Update scapy/layers/smb.py
MatrixEditor Mar 26, 2026
d283cb1
tests: add NETLOGON_LOGON_QUERY unit test
MatrixEditor Mar 27, 2026
e305200
Merge branch 'secdev:master' into fix/netlogon
MatrixEditor Apr 6, 2026
cc0e224
fix: apply netlogon padding correctly
MatrixEditor Apr 6, 2026
3ae1cf5
SMB & Netbios: better formatting
gpotter2 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scapy/layers/smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,10 @@ class NETLOGON_LOGON_QUERY(NETLOGON):
LEShortEnumField("OpCode", 0x7, _NETLOGON_opcodes),
StrNullField("ComputerName", ""),
StrNullField("MailslotName", ""),
ConditionalField(
ByteField("MailslotPad", default=0x00),
lambda pkt: (len(pkt.MailslotName) + 1) % 2 != 0
),
Comment thread
MatrixEditor marked this conversation as resolved.
Outdated
StrNullFieldUtf16("UnicodeComputerName", ""),
FlagsField("NtVersion", 0xB, -32, _NV_VERSION),
XLEShortField("LmNtToken", 0xFFFF),
Expand Down
Loading