Skip to content

enable PKCE for confidential dynamic clients #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alari wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

enable PKCE for confidential dynamic clients #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/data/src/entity/clients.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,7 +1881,11 @@ impl Client {
) as i32,
scopes,
default_scopes,
challenge: (!confidential).then_some("S256".to_string()),
// MCP / OAuth 2.1 clients always send a code_challenge, including when they
// register as confidential, so enable PKCE for every dynamic client rather
// than public ones only -- otherwise /authorize rejects them with
// "'code_challenge' not enabled for this client".
challenge: Some("S256".to_string()),
force_mfa: false,
client_uri: req.client_uri,
contacts: req.contacts.map(|c| c.join(",")).filter(|c| !c.is_empty()),
Expand Down
Loading