Orchestration skill: lanes never delegate their audit to /code-review - #92
Draft
lucasrcezimbra wants to merge 1 commit into
Draft
Orchestration skill: lanes never delegate their audit to /code-review#92lucasrcezimbra wants to merge 1 commit into
lucasrcezimbra wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lucasrcezimbra
marked this pull request as draft
August 18, 2026 00:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lesson
The built-in
/code-reviewspawns its reviewer with the session's working directory, not the directory the invoking agent happens to be working in. A build lane running in an isolated worktree that invokes it therefore gets a review of whatever branch the main checkout holds — and the reviewer runs the full gate set there too, which may be the live installation the worktree discipline exists to protect.The change
One charter bullet in the orchestration skill: a lane never delegates its audit to
/code-review; it hand-audits its own diff, and the independent review is the orchestrator's fan-out over the lane's committed branch.Evidence
While building #90, the lane invoked
/code-reviewfrom its worktree; the reviewer forked into the main checkout, reviewed the unrelatedissue-82-unavailable-backfillsbranch end to end, and ranlint/tsc/test:unit/test:e2e/test:seed-coveragein the live checkout. The lane caught it, hand-audited instead, and the orchestrator's three-finder fan-out supplied the independent review — but the wasted review and the gate runs in the live checkout are exactly what this sentence prevents.Clears the bar: durable (every future lane faces the same fork semantics), behavior-changing (charters stop delegating audits to a tool that cannot see the lane's branch), and placed where charter-writers already look.
🤖 Generated with Claude Code