Skip to content

Orchestration skill: lanes never delegate their audit to /code-review - #92

Draft
lucasrcezimbra wants to merge 1 commit into
seasonedcc:mainfrom
lucasrcezimbra:si/lane-code-review-cwd
Draft

Orchestration skill: lanes never delegate their audit to /code-review#92
lucasrcezimbra wants to merge 1 commit into
seasonedcc:mainfrom
lucasrcezimbra:si/lane-code-review-cwd

Conversation

@lucasrcezimbra

Copy link
Copy Markdown

The lesson

The built-in /code-review spawns its reviewer with the session's working directory, not the directory the invoking agent happens to be working in. A build lane running in an isolated worktree that invokes it therefore gets a review of whatever branch the main checkout holds — and the reviewer runs the full gate set there too, which may be the live installation the worktree discipline exists to protect.

The change

One charter bullet in the orchestration skill: a lane never delegates its audit to /code-review; it hand-audits its own diff, and the independent review is the orchestrator's fan-out over the lane's committed branch.

Evidence

While building #90, the lane invoked /code-review from its worktree; the reviewer forked into the main checkout, reviewed the unrelated issue-82-unavailable-backfills branch end to end, and ran lint/tsc/test:unit/test:e2e/test:seed-coverage in the live checkout. The lane caught it, hand-audited instead, and the orchestrator's three-finder fan-out supplied the independent review — but the wasted review and the gate runs in the live checkout are exactly what this sentence prevents.

Clears the bar: durable (every future lane faces the same fork semantics), behavior-changing (charters stop delegating audits to a tool that cannot see the lane's branch), and placed where charter-writers already look.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@lucasrcezimbra
lucasrcezimbra marked this pull request as draft August 18, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant