Skip to content

perf: "two-pass" seurat hvg via scanpy.get.aggregate #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ilan-gold wants to merge 19 commits into
base: main
Choose a base branch
from
+114 −35

fix: a little bit more

cf65665
Select commit
Loading
Failed to load commit list.
Draft

perf: "two-pass" seurat hvg via scanpy.get.aggregate #4013

fix: a little bit more
cf65665
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 0s

79.64% (target 75.00%)

View this Pull Request on Codecov

79.64% (target 75.00%)

Details

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.64%. Comparing base (45325b1) to head (cf65665).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/preprocessing/_highly_variable_genes.py 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4013      +/-   ##
==========================================
+ Coverage   79.62%   79.64%   +0.01%     
==========================================
  Files         120      120              
  Lines       12941    12958      +17     
==========================================
+ Hits        10304    10320      +16     
- Misses       2637     2638       +1
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_highly_variable_genes.py 94.68% <91.66%> (-0.39%) ⬇️

... and 1 file with indirect coverage changes

View more details on Codecov