Skip to content

Reject non-positive date_range steps #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodingFeng101 wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −0
Open

Reject non-positive date_range steps #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
696cb11
Reject non-positive date_range steps
CodingFeng101 Jun 20, 2026
4cbea3a
Move date_range step test into existing class
CodingFeng101 Jun 25, 2026
1150f2f
Apply pre-commit formatting to date_range test
CodingFeng101 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dateparser/date.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def date_range(begin, end, **kwargs):
step = relativedelta(**kwargs) if kwargs else relativedelta(days=1)

date = begin
if date + step <= date:
raise ValueError("date_range step must be positive")

while date < end:
yield date
date += step
Expand Down
10 changes: 10 additions & 0 deletions tests/test_date.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ def test_should_reject_easily_mistaken_dateutil_arguments(self, invalid_period):
)
self.then_period_was_rejected(invalid_period)

@parameterized.expand(
[
param(step={"months": 0}),
param(step={"days": -1}),
]
)
def test_should_reject_steps_that_do_not_advance(self, step):
with pytest.raises(ValueError, match="date_range step must be positive"):
next(date.date_range(datetime(2014, 6, 15), datetime(2014, 6, 25), **step))

def when_date_range_generated(self, begin, end, **size):
try:
self.result = list(date.date_range(begin, end, **size))
Expand Down