Adds a header for forum requests to bypass cloudflare - #121
Open
The-E wants to merge 3 commits into
Open
Conversation
notimaginative
requested changes
Aug 2, 2026
notimaginative
left a comment
notimaginative
left a comment
Contributor
There was a problem hiding this comment.
nightly_build.yml and release_build.yml need to be updated to set the FROUM_SECRET variable.
We should also have a quick fail if that variable isn't set at the start of the job.
…nightly and release workflow
notimaginative
requested changes
Aug 2, 2026
|
|
||
| # Assumes git has SirKnightly credentials already | ||
| def main(): | ||
| if "FORUM_SECRET" not in os.environ: |
Contributor
There was a problem hiding this comment.
Same comment from the other PR...
My python sucks, so excuse me if I'm off base here, but is that checking whether the variable is both present and set, or just present? Because, from my understanding, this check would pass even if the secret isn't set since the variable would still exist. We will need to catch both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.