Skip to content

More Search UI/UX Enhancements - #7612

Merged
JohnAFernandez merged 10 commits into
scp-fs2open:masterfrom
JohnAFernandez:More-search-fixes
Jul 30, 2026
Merged

More Search UI/UX Enhancements#7612
JohnAFernandez merged 10 commits into
scp-fs2open:masterfrom
JohnAFernandez:More-search-fixes

Conversation

@JohnAFernandez

@JohnAFernandez JohnAFernandez commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This has a few upgrades to the sexp search system, including:

  • Adding "Search for Replacement" to context (right-click) menu
  • Adding Ctrl+S as a shortcut to initiate search (and item edit)
  • Re-enabling search for numeric sexps (which seems to have been disabled by accident, understandable from how big the original PR was)
  • Keeps the search from picking results that have nothing to do with the searched string
  • Search results will now show strings that start with the search string first. More work would be required to further improve search, like sorting by how soon the search string appears in the text.
  • Double click will also now initiate search or item edit, depending on the node type, if there are no children to expand.

Each feature was individually tested, and I'm open to feedback on adjustments.

Fixes #7604

@JohnAFernandez JohnAFernandez self-assigned this Jul 16, 2026
@JohnAFernandez JohnAFernandez added the enhancement A new feature or upgrade of an existing feature to add additional functionality. label Jul 16, 2026
@JohnAFernandez JohnAFernandez added the qtfred A feature or issue related to qtFred. label Jul 16, 2026
@github-project-automation github-project-automation Bot moved this to Work In Progress (PRs) in qtFRED2 Jul 16, 2026
@JohnAFernandez JohnAFernandez changed the title More search fixes More Search UI/UX Enhancements Jul 16, 2026

@MjnMixael MjnMixael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. Looks overall pretty good.

Comment thread qtfred/src/ui/widgets/sexp_tree_view.cpp
Comment thread code/missioneditor/sexp_tree_model.cpp Outdated
Comment thread qtfred/src/ui/widgets/sexp_tree_view.cpp Outdated
Comment thread qtfred/src/ui/widgets/sexp_tree_view.cpp
@github-project-automation github-project-automation Bot moved this from Work In Progress (PRs) to In Review (PRs) in qtFRED2 Jul 20, 2026
Items that begin with the search string should be prioritized before those that simply contain the search string.
I didn't see any crashes, but this matches the pattern of other keyboard shortcuts.
The working code existed already
This limits matches on operator searches by setting a minimum size that a string match has to meet.  Function returns -1 on failure, and the warning has been removed to allow this behavior.
This allows ctrl+s (which can be listed instead of spacebar) to initiate search.  There is a new menu item added as well.
We want the item to be inserted here, not ignored.
@JohnAFernandez
JohnAFernandez merged commit 92384b3 into scp-fs2open:master Jul 30, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from In Review (PRs) to Done in qtFRED2 Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A new feature or upgrade of an existing feature to add additional functionality. qtfred A feature or issue related to qtFred.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Sexp View Search Enhancements

2 participants