QtFRED Generalized Mission/Campaign Save

[MjnMixael]

This moves FRED's missionsave.cpp into a common location so that QtFRED can take advantage of the well-tested code. With this in place we can be sure that QtFRED's mission output will be identical to FRED's.

I also took this opportunity to move campaign file saving into its own file and generalize how it works. It requires a little bit more overhead to call but should be UI/application agnostic now. The QtFRED campaign save call sites will be updated once this or #7030 is merged which should trigger a conflict in either PR.

There are a handful of other TODOs here which will be handled in follow-ups or as QtFRED work continues.

One minor upgrade is that campaign names now properly save XSTRs and campaign descriptions are now unlimited length. (The already parsed at a greater length than was allowed to save so this change makes round-tripping a campaign file through the editor work as expected.

EDIT: I should add that I tested round-tripping multiple missions and campaign files (including complex files from mods like BP, JAD, and BtA).

Fixes #7028

[TheForce172]

missionsave is missing the Guardian Threshold code added in #6989 and potentially other QT Fred only additions. I'm afraid you need to go through QTFred missonsave and see whether there were any more QTFred only additions/changes.

[MjnMixael]

missionsave is missing the Guardian Threshold code added in #6989 and potentially other QT Fred only additions. I'm afraid you need to go through QTFred missonsave and see whether there were any more QTFred only additions/changes.

I'm going to assume guardian threshold is the only thing missing as missionsave changes should always have been done to both files for exactly this reason. Given that up until now FRED was the source of truth, I feel safe assuming the guardian threshold code added in the QtFRED PR is the only outlier.

EDIT: Yes, a quick browse of QtFRED's history shows the primary PR authors are myself and Goober who religiously update both files. Checking the other outlying authors as far back as 2023 also show they updated both places. So I'm very comfortable assuming #6989 is the only change needed to port back in.

[JohnAFernandez]

We should watch for bugs in mission and campaign save for a while, but otherwise, this is a sensible change. Thanks for taking a look too, theforce

[MjnMixael]

Agreed. I'm pretty confident in the mission save part of this one as there were almost no changes to that code outside of Clang modernization. Campaign saving had more changes but the community stopped relying on that editor years ago so ymmv.

That said for merging this close to an RC stage I could go either way. On one hand merging means less maintenance with conflicts as people work with the existing mission save files. On the other it could introduce bugs to a critical piece of code at a possibly bad time. I leave it up to SCP to decide.

[MjnMixael]

Conflicts resolved. This now patches QtFRED's campaign editor to use the new campaign save method.

[wookieejedi]

Just noting, once stable is out, it would be great to have this PR as a priority merge to allow QT FRED updates to continue

[wookieejedi]

As noted on Discord, will plan to merge this over the weekend

[wookieejedi]

Update, some other FSO devs wanted some extra time to look, though nevertheless it remains a priority

[wookieejedi]

Yeah I had seen internal conversations saying that some folks would look over the PR, though my assumptions got the best of me as there was no actual request to postpone the merging. Alas I too hastily commented on the PR in an effort to maintain current and transparent communication. Apologies for unduly muddling the waters on this one! The plan is to indeed merge this over the weekend 🙂

[wookieejedi]

Will merge this in a few hours