fix(deps): close public extras under [all] (PS-221) - #158
Open
ywatanabe1989 wants to merge 1 commit into
Open
Conversation
The `dev` and `docs` extras were public but absent from `all`, so `pip install scitex-io[all]` silently under-installed 26 requirements. Close by inclusion via the self-referencing form, matching scitex-genai and scitex-stats.
Collaborator
Author
|
CI attribution (not caused by this PR):
Control: running The remaining 3 are pre-existing structural debt from the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS-221
public-extra-not-closed-under-all(severity E, blocking).Before: 26 findings. After: 0.
The
devanddocsextras are public but were absent fromall, sopip install scitex-io[all]silently under-installed 26 requirements — a user runs the documented "give me everything" install and still lacks the feature.Fixed by closure-by-inclusion using the self-referencing form, which cannot drift when a referenced extra changes. This matches the shape already shipped by scitex-genai and scitex-stats on develop.
The old comment claimed a self-reference "fails to resolve during editable installs". That constraint applies to a self-reference inside
[dev](still enumerated literally here), not to[all]; scitex-genai and scitex-stats ship the self-referencingalltoday. Comment corrected accordingly.No source changes;
pyproject.tomlonly. Verified withscitex-dev ecosystem audit-project scitex-io --rule PS-221(0 findings) and anuv build --sdistmetadata build.