ci: Add Test asymmetric ipv6 routing for parameter --oiface#468
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new CI test script, ci/test-oiface-ipv6.sh, to verify asymmetric IPv6 routing using fping within network namespaces. The feedback provided aims to enhance the script's robustness by recommending the use of mktemp for unique log files, consistent variable quoting to prevent word splitting, and more reliable path handling for the fping binary.
|
coverage: 87.888% (-0.1%) from 88.0% — gsnw:oiface-test-ipv6 into schweikert:develop |
gsnw-sebast
force-pushed
the
oiface-test-ipv6
branch
from
867cdd5 to
dc9f64e
Compare
gsnw-sebast
force-pushed
the
oiface-test-ipv6
branch
from
dc9f64e to
c14098e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the IPv4 test for --oiface, I have also added a working IPv6 test.