Skip to content

Add SMT plugin for Kafka Connect S3 object key partitioning

9f310a7
Select commit
Loading
Failed to load commit list.
Closed

Add SMT plugin for Kafka Connect S3 object key partitioning #2410

Add SMT plugin for Kafka Connect S3 object key partitioning
9f310a7
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review succeeded May 18, 2026 in 2m 20s

Claude Code Review: LGTM

LGTM — no issues found.

The SMT implementation is clean: stripObjectKey correctly handles V1 master, V1 version, and V0 legacy encodings; extractDocumentKeyId navigates the Struct defensively with appropriate debug logging for mismatches; the partition is correctly set to null so Connect re-hashes on the stripped key. Tests cover all encoding variants plus edge cases (empty keys, missing fields, non-string IDs). The Dockerfile build stage wiring is correct — kafka_version flows through kafka_build_vars.shenv.kafka_version → build-arg KAFKA_VERSION-Dkafka.version=, ensuring the SMT compiles against the shipped Kafka release. The prior review feedback (tests skipped via -DskipTests) has been addressed.