Add basic tests for PHP WASM grammar#1
Open
claytonrcarter wants to merge 3 commits into
Open
Conversation
Author
|
I just added a few more tests for the cases I mentioned in pulsar-edit#852 (comment), eg |
1240d09 to
893f684
Compare
16a6b4b to
50bfa51
Compare
Owner
|
Sorry, I didn't get a notification when you opened this. Even though it's my own repo! I will look over it when I can, but feel free to remind me if it's been a week or so. |
These tests and the scopes are meant to mimic the TextMate grammar and scopes, but the new tree-sitter grammar deviates in a few ways. The adjustments needed to make these pass are in the next commit.
This updates the tests to match the output of the new WASM grammar, except where I think the WASM grammar may be wrong.
These cover some of the cases mentioned at pulsar-edit#852 (comment)
893f684 to
6a7afbe
Compare
Author
No worries! I just rebased this onto your latest branch. Depending on what you think of #2, I may retarget this at that branch to add coverage for my changes. Maybe just for my own sanity?! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. As mentioned in pulsar-edit#852 (comment), these are some example tests that I updated from my original work on the legacy PHP tree-sitter grammar.
The first commit runs, but most of the tests fail because it's trying to match the output of the TM grammar pretty closely. The second commit updates the tests to better match your code. eg I removed the
punctuationscopes for semicolons, etc. Note that the second commit still has plenty of failures, because I found a few places where the new grammar maybe wasn't covering all of the bases. (eg??=,%andinstanceof).The failing output I see is:
Obviously happy to make any changes you'd like to see, or just to close this if you're not interested. Thank you!