Check HTTP status and Content-Length before parsing - #24
Merged
Conversation
Validate the HEAD response status (must be 2xx) and the presence of Content-Length header, raising clear errors instead of cryptic KeyError or struct unpacking failures. Co-Authored-By: midichef <midichef@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
saulpw
added a commit
to saulpw/visidata
that referenced
this pull request
Feb 15, 2026
Vendor updated unzip_http.py with HTTP status and Content-Length validation (saulpw/unzip-http#24). Catch errors from infolist() in iterload() so users see clean failure messages instead of tracebacks. Co-Authored-By: midichef <midichef@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
saulpw
added a commit
to saulpw/visidata
that referenced
this pull request
Feb 19, 2026
Vendor updated unzip_http.py with HTTP status and Content-Length validation (saulpw/unzip-http#24). Catch errors from infolist() in iterload() so users see clean failure messages instead of tracebacks. Co-Authored-By: midichef <midichef@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Lengthheader presence, instead of crashing withKeyErrorerror()function for clean error messagesInspired by error cases reported in saulpw/visidata#2655 by @midichef.
Test plan
cannot open URL: HTTP status 404instead of aKeyErrortracebackContent-Lengthgives a clear error🤖 Generated with Claude Code