Make section start "nullable" (represented by std::nullopt) - #45
Open
antis81 wants to merge 3 commits into
Open
Conversation
…onal Those will be serialized into the symbol table and can now hold an additional "nullopt" (-> None) status. However those values are still initialized with a -1 value and behave as if they were an "int". Means: None of section start/pc/size will run into an "undefined" status.
Note that whenever we use section start as an algorithmic value it has to be a "raw" int(!) FYI: Section start will still hold an int-value. The "else" in Machine::layoutSections() will not take effect because Check(section.start.has_value(), "Section must have start");
antis81
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic idea is to enable bass's
SymbolTableto interpretnullopt(aka "undefined", "None" or "nil") for typed arguments.Currently such state does not exist (which in worst case can result in output holding "false positive" bytes - e.g.
0xffsometimes means -1 and sometimes it should error out instead - ⚡)Addressing section "start", "pc" and "size" as a starting point.
To keep changes reviewable the logical behaviour of the assembler does not change here (at least not yet). What changes is only the comparison
section.start == -1vs!section.start.has_value()(alternativelysection.start == std::nullopt).