Rails 8.1 upgrade - #1771
Merged
Merged
Conversation
dasunpubudumal
commented
Jan 26, 2026
harrietc52
approved these changes
Jan 26, 2026
harrietc52
left a comment
harrietc52
left a comment
Contributor
There was a problem hiding this comment.
All looks good, just that dependency with the JSONAPI resource Gem could possibly be created linked with with PR
BenTopping
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1761
Changes proposed in this pull request
jsonapi-resourcesversion to fit Rails 8.1.pre-commitafter deciding what we want to include there (linting checks, unit tests, etc.). We don't want to add more checks than necessary and make developers mad!Note
The
Gemfileneeds to be updated with the proper version ofsanger-jsonapi-resourcesafter the correspondingjsonapi-resourcespull-request is merged. Sequencescape is pinned to an older version ofsanger-jsonapi-resources(i.e., 0.1.2) so we could easily use the new3.0.0version ofsanger-jsonapi-resourcesgem that the changes in the aforementionedsanger-jsonapi-resourcesPR introduce.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version