Skip to content

Fix for Rails 8.1 [Sequencescape] - #19

Merged
StephenHulme merged 19 commits into
developfrom
sh51/rails-8-1-fix
Aug 20, 2026
Merged

Fix for Rails 8.1 [Sequencescape] #19
StephenHulme merged 19 commits into
developfrom
sh51/rails-8-1-fix

Conversation

@StephenHulme

@StephenHulme StephenHulme commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Changes

  • Add support for Rails 8.1 and above
  • Fix for Rails 8.1 compatibility in Sequencescape
  • Remove support for Rails 7.1
  • Bump version to 0.1.4

Based on merge pull request #10

@StephenHulme

StephenHulme commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

Awaiting testing in Sequencescape before merging

@elias-sinc

elias-sinc commented Aug 17, 2026

Copy link
Copy Markdown

Hi @dasunpubudumal,

any progress here? We need this pull request.

@StephenHulme

StephenHulme commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

any progress here? We need this pull request.

Hi @elias-sinc,

This particular PR is specifically for Sequencescape - and not suitable for a general implementation of JSONAPI. If you are looking for general Rails 8.1 support, please have a look at https://rubygems.org/gems/sanger-jsonapi-resources/versions/0.3.0. This is the latest release of the master branch of the Sanger fork.

For planning purposes, this PR itself is likely to be released in a timescale of weeks, since the upgrade work to get Sequencescape to Rails 8.1 needs to happen first.

@elias-sinc

elias-sinc commented Aug 17, 2026

Copy link
Copy Markdown

@StephenHulme: OK, thank you very much!

@StephenHulme StephenHulme mentioned this pull request Aug 19, 2026
Merged
@StephenHulme StephenHulme self-assigned this Aug 20, 2026
BenTopping
BenTopping reviewed Aug 20, 2026
View reviewed changes
Comment thread lib/jsonapi/routing_ext.rb Outdated
Comment thread lib/jsonapi/routing_ext.rb Outdated
resources @resource_type, options do
resources @resource_type, **options do
# :nocov:
if @scope.respond_to? :[]=

@BenTopping BenTopping Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again we can drop the rails 4 if statement

@StephenHulme StephenHulme Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, can do 👍

@StephenHulme StephenHulme Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 509ac9a

@StephenHulme
StephenHulme merged commit fb1b720 into develop Aug 20, 2026
9 checks passed
@StephenHulme
StephenHulme deleted the sh51/rails-8-1-fix branch August 20, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTopping BenTopping BenTopping approved these changes

Assignees

@StephenHulme StephenHulme

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StephenHulme @elias-sinc @BenTopping @dasunpubudumal