Allow a compound to declare an ordered validation

[laritakr]

Summary

A compound metadata property can declare a rule relating two of its sub-properties, so an entry whose end date falls before its start date is refused.

Details

Nothing previously stopped a reversed range from saving: validation was per-sub-property, with no way to express a rule across two. This validation is declared on the compound rather than a sub-property:

  dates:
    data_type: array
    type: hash
    validations:
      - { type: ordered, before: start_date, after: end_date }

• ordered compares dates. A blank after (the usual case for an optional end date) is allowed, as are equal values; a value that does not parse as a date is skipped rather than flagged.
• One message per broken rule, not per offending row, matching how missing_required_subproperties dedupes. A row still missing a required: sub-property reports only that, so a half-filled entry doesn't raise two complaints.
• An unrecognized type: is carried through rather than rejected, so a profile written against a newer Hyrax still loads. A new profile-validation warning surfaces it, which stops a misspelling (ordred) from silently disabling the rule.
• Opt-in: compounds without validations: behave exactly as before.

[Copilot]

Pull request overview

Adds support for compound-level validation rules so a compound property can enforce ordering constraints across two sub-properties (e.g., end date must not precede start date), with profile-time warnings for rules that would otherwise be silently ignored.

Changes:

• Introduces normalized validations: on compound definitions and implements an ordered rule in Hyrax::CompoundEntryValidation.
• Adds a flexible-schema validator that warns on unknown/incomplete compound validation rules (non-blocking).
• Adds specs, documentation, and I18n strings for the new ordering rule and warnings.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
spec/services/hyrax/flexible_schema_validators/compound_validations_validator_spec.rb	Tests warning behavior for unknown/incomplete compound validation rules.
spec/services/hyrax/compound_schema_spec.rb	Verifies compound validations: are carried through schema definitions and default to empty.
spec/services/hyrax/compound_entry_validation_spec.rb	Tests ordered-rule behavior (in-order, equal, blank end date, deduped violations).
documentation/compound_fields.md	Documents validations: and the ordered rule semantics and messaging.
config/locales/hyrax.en.yml	Adds end-user error message for out-of-order entries and validator warning messages.
app/services/hyrax/flexible_schema_validators/compound_validations_validator.rb	Implements warning-only profile validation for compound validations: rules.
app/services/hyrax/flexible_schema_validator_service.rb	Wires the new compound validations validator into overall schema validation.
app/services/hyrax/compound_schema.rb	Normalizes compound validations: rules into the compound definition.
app/services/hyrax/compound_entry_validation.rb	Implements ordered validation and emits :out_of_order violations.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Test Results

1 928 tests  +2   1 928 ✅ +2   0s ⏱️ ±0s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit bcef2c1. ± Comparison against base commit 4343ff2.