Fix Current Version Numbers - #7576
Open
orangewolf wants to merge 5 commits into
Open
Conversation
* Scope redirects form property to works and collections The redirects form property and its validator now live on PcdmObjectForm and PcdmCollectionForm rather than the shared ResourceForm, so FileSetForm no longer inherits a property its model does not back. With redirects enabled in non-flexible mode, Reform builds the form twin by reading every declared property off the model. FileSet has no `redirects` attribute, so inheriting the property from ResourceForm raised NoMethodError when editing or validating a FileSet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * remove confusing and unnecessary comment --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Rob Kaufman <rob@notch8.com>
Test Results 17 files ±0 17 suites ±0 3h 26m 15s ⏱️ + 4m 44s Results for commit 55ef39c. ± Comparison against base commit c57d5bb. This pull request removes 447 and adds 444 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cjcolvar
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 5.3 was released the version number changes got in to the tagged branch but not in to main. This fixes that.